Correct testPoint for organized nearest neighbor search #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was perceiving occasional spikes in the computation time for kNN search. This is due to the search box not being updated when adding the k-th neighbor and subsequent iterations of the do-while loop in kNN search never trigger the else case in testPoint. This way we iterate over way too many points during search.
wannesvanloock
force-pushed
the
fix/organized_nearest_neighbor
branch
from
44adb56 to
ae742e9
Compare
|
Friendly ping to the developers. What is holding back review on this PR? Is there anything I can do to accelerate the process? |
|
Could you please explain why it is not |
|
This line should get called whenever the top element in the results queue changes (As long as the queue is not full it should |
SergioRAgostinho
removed
the
needs: code review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing occasional spikes in the computation time for organized kNN search. This is due to the search box not being updated when adding the k-th neighbor and subsequent iterations of the do-while loop in kNN search never trigger the else case in
testPoint. This way we iterate over way too many points during search.The plot below shows a histogram of the log10 computation time before (top) and after (bottom) the fix for
k=20for every point on a particularly problematic point cloud. Note the grouping around -3 on the before plot. On this point cloud, this reduces the average computation time of nearest neighbor searches by a factor 20. On other clouds I see around a factor 2 improvement.