Do not use deprecated method in openni_mls_smoothing app #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRAgostinho
approved these changes
Sep 9, 2018
|
Good catch. I'll just wait for CI to build. |
apps/src/openni_mls_smoothing.cpp
Outdated
| if (pcl::console::parse_argument (argc, argv, "-polynomial_order", polynomial_order) == -1 ) | ||
| use_polynomial_fit = true; | ||
| pcl::console::parse_argument (argc, argv, "-use_polynomial_fit", use_polynomial_fit); | ||
| pcl::console::parse_argument (argc, argv, "-polynomial_order", polynomial_order) |
There was a problem hiding this comment.
CI just failed. Sintax error here. Needs the semicolon at the end.
There was a problem hiding this comment.
And how on Earth did it succeed to build locally? Mystery.
PR PointCloudLibrary#1960 deprecated `setPolynomialFit()` but did not update the openni_mls_smoothing app.
taketwo
force-pushed
the
fix-deprecations
branch
from
5d984ef to
08c0ab7
Compare
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1960 deprecated
setPolynomialFit()but did not update theopenni_mls_smoothingapp.