Relax requirements in eigen22d test. Always provide a normalized result in pcl::transformPlane.
#2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just discovered the eigen22f test is still failing on my 18.04 environment. Gonna have a look at it again although I'm fearing this is gonna get us back to the original problems in #1702. |
|
This one is also good to go. |
taketwo
reviewed
Oct 7, 2018
test/common/test_eigen.cpp
Outdated
| // From Eigen 3.3.2 onwards, the Eigen::Hyperplane::transform always returns | ||
| // coefficients with the normal normalized | ||
| #if EIGEN_VERSION_AT_LEAST (3, 3, 2) | ||
| test /= test.head<3> ().norm (); |
There was a problem hiding this comment.
Shouldn't we rather tweak the function to return consistent results no matter what the Eigen version is? That is, to return normalized normal?
There was a problem hiding this comment.
Yes, that sounds cleaner.
SergioRAgostinho
force-pushed
the
test-eigen
branch
from
b840192 to
dd9a40a
Compare
SergioRAgostinho
force-pushed
the
test-eigen
branch
from
dd9a40a to
d56ce85
Compare
|
Don't let this one be forgotten. |
taketwo
changed the title
pcl::transformPlane.
|
Thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.