Remove CMake config installation folder only when empty #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
approved these changes
Nov 15, 2018
|
I will test and report this change today. |
|
It seems to work properly on Windows. Are other platforms okay? |
|
The changes you did are OK in OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we change, and fix under Windows, the behavior of the uninstall target when uninstalling the installed CMake configuration file folder.
The first commit, d05e0ed, is the proposed solution to the problem.
The second and last commit, e73d7d1, unifies the CMake style in
cmake/uninstall_target.cmake.in.We can drop the second commit if you feel it should not be applied.
Fixes #2615 (see a detailed discussion there).