Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set BOOST_ROOT to BOOST_ROOT_1_69_0 in Azure Windows job #3894

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Apr 8, 2020

One of the recent updates to the agent images used on Azure removed BOOST_ROOT variable: actions/runner-images@e91f213

@kunaltyagi
Copy link
Member

Same error (Boost not found)

@SergioRAgostinho
Copy link
Member

Our CMake file might be relying on the env BOOST_ROOT actually being set. Setting it to %BOOST_ROOT_1_69_0% might provide the fix

@kunaltyagi
Copy link
Member

Seems like the FindBoost in CMake relies on BOOST_ROOT

@taketwo taketwo force-pushed the fix-win-job branch 3 times, most recently from 759c867 to 1a08837 Compare April 9, 2020 11:16
@taketwo taketwo marked this pull request as ready for review April 9, 2020 11:25
@taketwo
Copy link
Member Author

taketwo commented Apr 9, 2020

Thanks for suggestions.

Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI (which appears to be going the green way)

@SergioRAgostinho
Copy link
Member

The CI gods are against us.

  The following tests FAILED:
  	  1 - test_2d (Exit code 0xc0000135
  )
  	 24 - common_centroid (Exit code 0xc0000135
  )
  	 28 - feature_base (Exit code 0xc0000135
  )
  	 29 - feature_cppf_estimation (Exit code 0xc0000135
  )
  	 30 - feature_normal_estimation (Exit code 0xc0000135
  )
  	 31 - feature_pfh_estimation (Exit code 0xc0000135
  )
  	 32 - feature_cvfh_estimation (Exit code 0xc0000135
  )
  	 33 - feature_ppf_estimation (Exit code 0xc0000135
  )
  	 34 - feature_shot_estimation (Exit code 0xc0000135
  )
  	 35 - feature_boundary_estimation (Exit code 0xc0000135
  )
  	 36 - feature_curvatures_estimation (Exit code 0xc0000135
  )
  	 37 - feature_spin_estimation (Exit code 0xc0000135
  )
  	 38 - feature_rsd_estimation (Exit code 0xc0000135
  )
  	 39 - feature_grsd_estimation (Exit code 0xc0000135
  )
  	 40 - feature_invariants_estimation (Exit code 0xc0000135
  )
  	 41 - feature_board_estimation (Exit code 0xc0000135
  )
  	 42 - feature_flare_estimation (Exit code 0xc0000135
  )
  )
  	110 - sample_consensus_plane_models (Exit code 0xc0000135
  )
  Errors while running CTest

I vote for merge regardless.

@taketwo taketwo changed the title Replace BOOST_ROOT with BOOST_ROOT_1_69_0 in Azure Windows job Set BOOST_ROOT to BOOST_ROOT_1_69_0 in Azure Windows job Apr 9, 2020
@taketwo
Copy link
Member Author

taketwo commented Apr 9, 2020

We had this issue already (#2632, #2935) and according to #2935 (comment), the problem lies in Boost directories not set in the system PATH variable.

taketwo added 2 commits April 9, 2020 17:12
One of the recent updates to the agent images used on Azure removed BOOST_ROOT variable: actions/runner-images@e91f213, however it is needed by the CMake Boost finder scripts.
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We leave the env variable printing for debugging purposes on the CI?

@taketwo
Copy link
Member Author

taketwo commented Apr 10, 2020

Yes! It's handy to have them printed always.

@taketwo taketwo merged commit 41a9d02 into PointCloudLibrary:master Apr 10, 2020
@taketwo taketwo deleted the fix-win-job branch April 10, 2020 07:00
@SergioRAgostinho SergioRAgostinho removed their request for review April 11, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants