Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform point cloud in GICP align function #887

Merged
merged 1 commit into from
Sep 11, 2014
Merged

Transform point cloud in GICP align function #887

merged 1 commit into from
Sep 11, 2014

Conversation

VictorLamoine
Copy link
Contributor

Fixes #754 and #818
I also fixed a dead link in the GICP documentation.

The new changes can be tested using the following code; which is a modified copy of Interactive ICP tutorial code. Test project

I use a GICP object rather than an ICP object; here I use the align function with a guessed matrix
icp.align (*cloud_icp, transformation_matrix.inverse ().cast<float> ());

Note that transformation_matrix.inverse () is the exact transformation to align the point cloud. As a result the point cloud is perfeclty aligned after the first iteration.

If you want to see GICP working just use
icp.align (*cloud_icp);
And press space in the viewer to iterate!

@VictorLamoine
Copy link
Contributor Author

@saarnold and @prclibo: Any comment on this?

jspricke added a commit that referenced this pull request Sep 11, 2014
Transform point cloud in GICP align function
@jspricke jspricke merged commit 71b1077 into PointCloudLibrary:master Sep 11, 2014
@VictorLamoine VictorLamoine deleted the gicp_fix branch September 11, 2014 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a guess transformation in GICP alignment leads to wrong results.
2 participants