Initial checkin for local min/max filter #927
Conversation
|
Do I understand right that this class provides a superset of functionality added by #577? |
|
Yes. I worked with the author of #577 to create this class. We wanted to create a filter which maintained the functionality of local maximum, but also added additional locality search methods and statistics. Additionally, I tweaked the algorithm to better support OpenMP. So, yes, this is a superset of #577. I wasn't sure if you would want to replace local_maximum with this filter, or maintain them both. Either way, I figured you guys would make that call. Thanks! |
|
I almost forgot, I also added options to project your point cloud to a user-specified plane before applying the filter. That way, a user can filter on more than just the z-dimension if they want. |
|
I do not think there are any reasons (besides backwards compatibility) to keep around the old class once the new powerful one is merged. @jspricke The old one was released into 1.7.2, which means that we can not silently abolish it, right? What if we mark it as deprecated, remove the actual implementation simply forwarding to the new one? |
| * Software License Agreement (BSD License) | ||
| * | ||
| * Point Cloud Library (PCL) - www.pointclouds.org | ||
| * Copyright (c) 2009-2012, Willow Garage, Inc. |
There was a problem hiding this comment.
I think Willow Garage has nothing to do with the code :)
Right.
Should be possible. |
| #ifdef _OPENMP | ||
| #pragma omp parallel for num_threads (threads_) schedule (dynamic) | ||
| #endif | ||
| for (int i = 0; i < cloud_projected->size(); i++) |
|
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
|
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
|
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
No description provided.