4.0 release, memory leaks fixes #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cierpliwy
reviewed
Oct 19, 2017
Source/BluetoothManager.swift
Outdated
| return self.centralManager.retrieveConnectedPeripherals(withServices: serviceUUIDs) | ||
| let observable = Observable<[Peripheral]>.deferred { [weak self] in | ||
| guard let strongSelf = self else { throw BluetoothError.destroyed } | ||
| return strongSelf.centralManager.retrieveConnectedPeripherals(withServices: serviceUUIDs) | ||
| .map { (peripheralTable: [RxPeripheralType]) -> |
There was a problem hiding this comment.
strongSelf will be locked during retrieveConnectedPeripherals ??
Source/BluetoothManager.swift
Outdated
| .map { (peripheralTable: [RxPeripheralType]) -> | ||
| [Peripheral] in peripheralTable.map { | ||
| Peripheral(manager: self, peripheral: $0) | ||
| Peripheral(manager: strongSelf, peripheral: $0) |
jwhitley
reviewed
Oct 19, 2017
RxBluetoothKit.podspec
Outdated
| @@ -20,5 +20,5 @@ Pod::Spec.new do |s| | |||
|
|
|||
| s.source_files = 'Source/*.swift' | |||
| s.frameworks = 'CoreBluetooth' | |||
| s.dependency 'RxSwift', '4.0.0-rc.0' | |||
| s.dependency 'RxSwift', '4.0.0' | |||
There was a problem hiding this comment.
It seems like you'd much rather have a dependency like s.dependency 'RxSwift', '~> 4.0', instead of a hard dependency on 4.0.0.
There was a problem hiding this comment.
That's right, thank you!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156 , final preparation for official 4.0 release