Always connect to a peripheral before trying to communicate with it #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re trying to communicate with it. This fixes a state restoration issue where the app relaunched in background couldn't communicate with known peripheral. The problem was that the reported state of the restored peripheral was connected and RxBluetoothKit would skip connecting to it. As Apple documents it everywhere, we should connect to a peripheral in all cases. "Even though the device is already connected to the system, you must still connect it locally to your app to begin exploring and interacting with it"
|
|
emixb
changed the title
|
Hi @emixb! Thank you for your PR. Can you update tests in the project? One test does not pass after your changes. |
minixT
requested changes
May 17, 2019
Hi @minixT, I updated the tests. Thanks! |
minixT
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Apple's recommendation and always connect to a peripheral before trying to communicate with it. This fixes a state restoration issue where the app relaunched in background couldn't communicate with known peripheral. The problem was that the reported state of the restored peripheral was connected and RxBluetoothKit would skip connecting to it. As Apple documents it everywhere, we should connect to a peripheral in all cases. "Even though the device is already connected to the system, you must still connect it locally to your app to begin exploring and interacting with it"