Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab Polus Render 0.1.0 #39

Merged
merged 36 commits into from
Nov 30, 2023
Merged

JupyterLab Polus Render 0.1.0 #39

merged 36 commits into from
Nov 30, 2023

Conversation

jcaxle
Copy link
Contributor

@jcaxle jcaxle commented Nov 22, 2023

Can be installed using pip install "git+https://github.com/jcaxle/jupyterlab-extensions.git@render#egg=jupyterlab_polus_render&subdirectory=jupyterlab_polus_render"

nb_render() is now render(), render()'s nb_root argument does not need to be modified on Notebooks Hub since it is /home/jovyan/ by default

image

Test files:
pyramid.zarr.zip

test_json.zip

Image links:
https://viv-demo.storage.googleapis.com/brain.pyramid.ome.tif
https://files.scb-ncats.io/pyramids/segmentations/x00_y01_c1.ome.tif
https://viv-demo.storage.googleapis.com/12448_G1HR_Mesh003.ome.tif

Overlay links:
https://files.scb-ncats.io/pyramids/segmentations/x00_y01_c1_segmentations.json

@jcaxle jcaxle requested a review from ktaletsk as a code owner November 22, 2023 19:37
Copy link

sweep-ai bot commented Nov 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@jcaxle jcaxle requested a review from ktaletsk November 29, 2023 20:49
@ktaletsk ktaletsk changed the title Render JupyterLab Polus Render 0.1.0 Nov 30, 2023
Copy link
Collaborator

@ktaletsk ktaletsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@ktaletsk ktaletsk merged commit b70594b into PolusAI:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants