Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rtc mentions of jupyterlab 4 #40

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix/rtc mentions of jupyterlab 4 #40

merged 2 commits into from
Dec 6, 2023

Conversation

ktaletsk
Copy link
Collaborator

Clean up remaining mentions of JupyterLab 3.x in RTC extension

@ktaletsk ktaletsk requested a review from sclaybon November 30, 2023 05:43
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

sclaybon
sclaybon approved these changes Nov 30, 2023
View reviewed changes
Copy link

@sclaybon sclaybon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

sclaybon
sclaybon approved these changes Dec 6, 2023
View reviewed changes
Copy link

@sclaybon sclaybon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ktaletsk ktaletsk merged commit ab9661a into PolusAI:master Dec 6, 2023
@ktaletsk ktaletsk deleted the fix/rtc-mentions-of-jupyterlab-4 branch December 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sclaybon sclaybon sclaybon approved these changes

@sunnielyu sunnielyu sunnielyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaletsk @sclaybon @sunnielyu