Add Apache Arrow support to Mac and Ubuntu PyPI wheels #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JesseMckinzie
commented
Nov 8, 2023
JesseMckinzie
commented
- Add Apache Arrow builds for PyPI wheels
- Remove pyarrow linking from C++ since the arrow::table is no longer constructed in C++
- Add Apache Arrow build to build script
- Add additional build script for installing Apache Arrow through yum
Apply Sweep Rules to your PR?
|
sameeul
reviewed
Nov 8, 2023
.github/workflows/build_wheels.yml
Outdated
| CIBW_TEST_COMMAND: pytest {project}/tests/python -m "not arrow" | ||
| CIBW_TEST_COMMAND_MACOS: pytest {project}/tests/python | ||
| CIBW_TEST_COMMAND_LINUX: pytest {project}/tests/python | ||
| CIBW_TEST_COMMAND_WINDOW: pytest {project}/tests/python -m "not arrow" |
There was a problem hiding this comment.
Missing S CIBW_TEST_COMMAND_WINDOWS
sameeul
reviewed
Nov 8, 2023
CMakeLists.txt
Outdated
| message(WARNING "The Arrow library was not found. The build will continue without Arrow support.") | ||
| set(USE_ARROW OFF) | ||
| endif() | ||
|
|
||
| find_package(Parquet) | ||
| if (NOT Arrow_FOUND) |
sameeul
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.