Analyze my sleep - front-end #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelfodil
force-pushed
the
upload-sleep
branch
from
8307157 to
f6468b4
Compare
conorato
reviewed
Sep 21, 2020
There was a problem hiding this comment.
Good job!
On pourrait aussi ajouter quelques validations du côté client pour guider l'utilisateur:
- Browse file: Accepter un fichier
.txtou.csvseulement (si c'est possible, seulement permettre à l'utilisateur de choisir les fichiers avec ces extensions quand il browse (les autres fichiers étant grisés)). - Age: un nombre entre 0 et 125 (à mettons)
Quand on appuie sur le bouton pour soumettre le fichier, on pourrait vérifier que tous les champs sont remplis avant d'envoyer la requête au serveur.
abelfodil
force-pushed
the
upload-sleep
branch
2 times, most recently
from
aa6b75b to
2f5309a
Compare
abelfodil
force-pushed
the
upload-sleep
branch
from
2f5309a to
fd4ecc6
Compare
conorato
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.