Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Howto guide #57

Merged
merged 34 commits into from
Nov 7, 2020
Merged

Howto guide #57

merged 34 commits into from
Nov 7, 2020

Conversation

abelfodil
Copy link
Contributor

No description provided.

@abelfodil abelfodil force-pushed the guide branch 4 times, most recently from 6db8b0a to 0f17354 Compare November 4, 2020 21:48
@abelfodil abelfodil marked this pull request as ready for review November 6, 2020 21:58
Copy link
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour les quelques illustrations qu'il manque, j'ai demander de les ajouter cotton swabs, rubbing alcohol, batteries, pen. Pour les paragraphes un peu vides, on pourra simplement regrouper les différents éléments ensemble :)

web/src/views/record_my_sleep/text.json Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Show resolved Hide resolved
Copy link
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter une section How we did it. J'ajouterai par la suite les photos qui seront dans le carroussel. Peut-être ajouter des background de d'autre couleur, cela fait un peu drabe les deux sections de gris.

web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
@WilliamHarvey97
Copy link
Contributor

Ah oui, et on a les images pour les étapes pour préparer les électrodes.
Ten202
ec22
gauze2

Copy link
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il ne manque plus que la section How we do it? Voici les images en ordre qu'on peut mettre dans le carroussel. Peut-être aussi ajouter un call to action et mettre un lien vers le formulaire pour uploader ses recordings à la fin du guide 👍

web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
web/src/views/record_my_sleep/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@abelfodil abelfodil merged commit 576d898 into master Nov 7, 2020
@abelfodil abelfodil deleted the guide branch November 7, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants