Validate signal #65
Merged
Validate signal #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MouradLachhab
requested review from
abelfodil and
WilliamHarvey97
and removed request for
abelfodil
|
What if qu'on teste le signal continuellement pis qu'on bloque le "Next" tant que le signal est pas valide pendant genre au moins 5s ? Ça enlève le besoin de cliquer sur un bouton pour valider |
Sure yea, je vais voir ça demain mais ça devrait bien se faire. |
|
New UI using continuous validation.
|
abelfodil
requested changes
Nov 8, 2020
mobile/lib/src/infrastructure/connection_repositories/eeg_data_repository.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/infrastructure/connection_repositories/eeg_data_repository.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/presentation/pages/record_sleep/signal_section.dart
Outdated
Show resolved
Hide resolved
abelfodil
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for code and UI changes. Validation will have to be tested on someone eventually.