Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock the cheat code of the universe #79

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Unlock the cheat code of the universe #79

merged 3 commits into from
Nov 13, 2020

Conversation

abelfodil
Copy link
Contributor

@abelfodil abelfodil commented Nov 12, 2020

Huge performance boost

image

@@ -166,7 +166,7 @@ const UploadForm = () => {
// prettier-ignore
const streamStart = new Date(`${getValues('stream_start_date')} ${getValues('stream_start_time')}`);
const bedTime = new Date(`${getValues('bedtime_date')} ${getValues('bedtime_time')}`);
if (streamStart > bedTime) {
if (streamStart >= bedTime) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to PR, but it triggered me

Copy link
Contributor

@conorato conorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why backend/web/? I find it confusing with web/ folder. Otherwise, seems good to me!

@abelfodil
Copy link
Contributor Author

Why backend/web/? I find it confusing with web/ folder. Otherwise, seems good to me!

Hmmm pcq c'est le http server. Maybe http instead?

@abelfodil abelfodil merged commit 2ac7bb2 into master Nov 13, 2020
@abelfodil abelfodil deleted the performance branch November 13, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants