Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter mouse events without left button #2166

Closed
dfreedm opened this issue Jul 29, 2015 · 0 comments
Closed

Filter mouse events without left button #2166

dfreedm opened this issue Jul 29, 2015 · 0 comments
Assignees
@dfreedm
Labels
enhancement p1

Comments

@dfreedm
Copy link
Member

dfreedm commented Jul 29, 2015

Nobody wants right or middle mouse buttons to generate gestures.

The "up" gesture and track gesture with state "end" will always be generated to not surprise developers.
Events used for testing (CustomEvents with MouseEvent types) will not be required to specify button or buttons properties unless testing specifically for non-left input.

This replaces PolymerElements/iron-behaviors#23, and handles right-click cases more accurately.
@dfreedm dfreedm self-assigned this Jul 29, 2015
dfreedm added a commit that referenced this issue Jul 29, 2015
@dfreedm
Automatically filter mouseevents without the left mouse button
806690f 
Keep test compatibility by treating undefined button values as left mouse button

Fixes #2166
@dfreedm dfreedm mentioned this issue Jul 29, 2015
Merged
dfreedm added a commit that referenced this issue Jul 29, 2015
@dfreedm
Automatically filter mouseevents without the left mouse button
bbc3b57 
Keep test compatibility by treating undefined button values as left mouse button

Fixes #2166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
enhancement p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfreedm