Templatize: remove slots when hiding children #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4977. When templatized content is hidden (via `_showHideChildren`) as in `dom-if` top level `<slot>` elements are now removed instead of being hidden. This ensures that assigned nodes are not displayed in false-y dom-if elements.
|
While it works, it does feel weird to remove these slots. Would this solution still work if you change the light dom nodes? |
kevinpschaaf
requested changes
Jan 2, 2018
lib/utils/templatize.html
Outdated
| } else if (n.localName === 'slot') { | ||
| if (hide) { | ||
| n.__polymerParent__ = n.parentNode; | ||
| n.__polymerSibling__ = n.nextSibling; |
There was a problem hiding this comment.
If the sibling was removed (e.g. due to dom-if going false) then the slot would never come back.
May be better to replaceChild with a non-slot?
TimvdLippe
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
Looking at this again, it makes more sense to me. Echoing @kevinpschaaf comment regarding the sibling. Not sure how we can handle that. We somehow have to keep track of where we were in the tree and insert it there. Replacing with non-slot and hide that seems like a 👌 solution
added 2 commits
January 29, 2018 12:08
This change makes the slot not depend on its nextSibling being stable in dom which is problematic if, for example, its nextSibling is a restamping dom-if which becomes false.
TimvdLippe
reviewed
Jan 31, 2018
lib/utils/templatize.html
Outdated
| const parent = n.__polymerParent__; | ||
| const replace = n.__polymerReplaced__; | ||
| if (parent && replace) { | ||
| parent.replaceChild(n, n.__polymerReplaced__); |
There was a problem hiding this comment.
Nit: can be parent.replaceChild(n, replace)
kevinpschaaf
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4977. When templatized content is hidden (via
_showHideChildren) as indom-iftop level<slot>elements are now removed instead of being hidden. This ensures that assigned nodes are not displayed in false-y dom-if elements.