-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 one click trading connector #25
base: master
Are you sure you want to change the base?
Conversation
src/connectors/OneClickTrading.sol
Outdated
IDefaultImpl(address(this)).toggleBeta(); | ||
} | ||
|
||
function isBeta() public payable returns (bool){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this
src/connectors/OneClickTrading.sol
Outdated
|
||
string public constant name = "One-Click-Trading-v1"; | ||
|
||
function enableAuth(address _user, uint256 _expiry) public payable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add events like normal connector
src/connectors/OneClickTrading.sol
Outdated
contract OneClickTrading is BaseConnector { | ||
using SafeTransferLib for ERC20; | ||
|
||
struct Data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
} | ||
|
||
contract OneClickTrading is BaseConnector { | ||
using SafeTransferLib for ERC20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
src/connectors/OneClickTrading.sol
Outdated
import {SafeTransferLib} from "solmate/utils/SafeTransferLib.sol"; | ||
import {BaseConnector} from "../utils/BaseConnector.sol"; | ||
|
||
interface IEmitter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
No description provided.