Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Provider Tests #494

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Feat: Provider Tests #494

merged 13 commits into from
Aug 22, 2024

Conversation

narengogi
Copy link
Collaborator

@narengogi narengogi commented Aug 2, 2024

Title:

  • Tests for providers to make sure they are OpenAI compliant

Initial idea for this sprung from reading the very descriptive GitHub issue raised by @raulraja #116

Motivation: (optional)

  • Multiple provider's transformers are not OpenAI spec compliant, they fail to transform cases like user message content array
    {
      role: 'user',
      content: [
        {
          type: 'text',
          text: 'Who is the greatest detective',
        },
      ],
    }
  • Already caught 6 transformers failing from 12 I tested for the two test cases.

Related Issues: (optional)

TO-DO:

  • Push config file
  • [For Later] Add flag to test only specific providers
  • [For Later] GitHub actions

@narengogi
Copy link
Collaborator Author

For your review @VisargD @sk-portkey

Copy link
Collaborator

@sk-portkey sk-portkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move from feature specific to provider level testing

@narengogi narengogi requested a review from sk-portkey August 13, 2024 09:32
sk-portkey
sk-portkey previously approved these changes Aug 13, 2024
@sk-portkey
Copy link
Collaborator

@narengogi can you update to main. else lgtm

@VisargD VisargD merged commit 38b4c69 into Portkey-AI:main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants