Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Audio Transcription and Translation routes support #501

Closed
wants to merge 7 commits into from
Closed

OpenAI Audio Transcription and Translation routes support #501

wants to merge 7 commits into from

Conversation

narengogi
Copy link
Collaborator

@narengogi narengogi commented Aug 12, 2024 •
edited
Loading

Description: (optional)

  • Add support for transcriptions and translations routes

Related Issues: (optional)

TODO

  • Refactor the code

Refactoring to do

  • Think of an alternative to hardcoding MULTIPART_FORM_DATA_ROUTES (try to check request body type)
  • Theres two places at which the MULTIPART_FORM_DATA_ROUTES check is applied, make it only one
  • Why are we setting content-type as multipart/formdata and removing it? let the headers be auto inferred

@VisargD VisargD self-requested a review August 22, 2024 10:09
@narengogi narengogi force-pushed the feature/transcription-route-support branch from 33bd979 to 572e98d Compare August 24, 2024 08:47
@narengogi
Copy link
Collaborator Author

changes now in #538

@narengogi narengogi closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VisargD VisargD Awaiting requested review from VisargD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@narengogi