Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zod validation for vertex #733

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: zod validation for vertex #733

merged 3 commits into from
Nov 7, 2024

Conversation

b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Nov 5, 2024

Title:

  • Fix zod validation for vertex.

Motivation: (optional)

  • Why this change is necessary or beneficial

Related Issues: (optional)

narengogi
narengogi approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@narengogi narengogi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would recommend adding a little more context and description to the PR or in a GitHub issue

@VisargD VisargD merged commit de18ab9 into Portkey-AI:main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narengogi narengogi narengogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b4s36t4 @narengogi @VisargD