Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update guardrail handler #888

Closed
wants to merge 9 commits into from
Closed

chore: update guardrail handler #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1cdd1e
chore: update guardrail handler
b4s36t4 Jan 24, 2025
1f1991a
chore: remove redaction as a seaprate guardrail and merge them with e…
VisargD Jan 25, 2025
6c06047
chore: allow guardrail hook type to transform req and res
VisargD Jan 25, 2025
271b779
chore: merge redaction in existing guardrails as a parameter
VisargD Jan 25, 2025
d3a73a7
chore: update plugin test cases for redaction
VisargD Jan 25, 2025
ca24ef4
fix: handle string content in set content part plugin util
VisargD Jan 25, 2025
77acd8a
Merge branch 'feat/redaction-guardrails-revamp' into feat/bedrock-gua…
b4s36t4 Jan 25, 2025
86e272d
chore: rename file
b4s36t4 Jan 25, 2025
a2d29a0
Merge branch 'feat/bedrock-guardrails' of github.com:b4s36t4/Rubeus i…
b4s36t4 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 74 additions & 74 deletions plugins/bedrock/index.test.ts → plugins/bedrock/bedrock.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { PluginContext, PluginParameters } from '../types';
import { BedrockParameters, pluginHandler } from './index';
import { bedrockPIIHandler } from './redactPii';
import { pluginHandler } from './index';
import creds from './.creds.json';
import { BedrockParameters } from './type';

/**
* @example Parameters object
Expand Down Expand Up @@ -90,7 +90,7 @@ describe('Credentials check', () => {
expect(result).toBeDefined();
expect(result.verdict).toBe(false);
expect(result.error).toBe(null);
expect(result.data.customWords).toHaveLength(1);
expect(result.data).toBeDefined();
});

test('Should be working with content_filter', async () => {
Expand All @@ -113,77 +113,77 @@ describe('Credentials check', () => {
expect(result).toBeDefined();
expect(result.verdict).toBe(false);
expect(result.error).toBe(null);
expect(result.data.filters).toHaveLength(1);
expect(result.data).toBeDefined();
});

test('Should work fine with redaction for sensitive info', async () => {
const context = {
response: {
json: {
choices: [
{
message: {
content:
'Hello, John doe. How are you doing?. I see your email is [email protected]',
},
},
],
},
},
requestType: 'chatComplete',
};

const parameters: PluginParameters<BedrockParameters['credentials']> = {
...creds,
};

const result = await bedrockPIIHandler(
context as unknown as PluginContext,
parameters,
'afterRequestHook',
{ env: {} }
);

const outputMessage =
result.transformedData?.response.json.choices[0].message.content;
expect(result).toBeDefined();
expect(result.verdict).toBe(true);
expect(outputMessage).toEqual(
'Hello, {NAME}. How are you doing?. I see your email is {EMAIL}\n'
);
});

test('Should work fine with regex redaction for sensitive info', async () => {
const context = {
response: {
json: {
choices: [
{
message: {
content: 'bedrock-12121, bedrock-12121',
},
},
],
},
},
requestType: 'chatComplete',
};

const parameters: PluginParameters<BedrockParameters['credentials']> = {
...creds,
};

const result = await bedrockPIIHandler(
context as unknown as PluginContext,
parameters,
'afterRequestHook',
{ env: {} }
);

const outputMessage =
result.transformedData?.response.json.choices[0].message.content;
expect(result).toBeDefined();
expect(result.verdict).toBe(true);
expect(outputMessage).toBe('{bedrock-id}, {bedrock-id}\n');
});
// test('Should work fine with redaction for sensitive info', async () => {
// const context = {
// response: {
// json: {
// choices: [
// {
// message: {
// content:
// 'Hello, John doe. How are you doing?. I see your email is [email protected]',
// },
// },
// ],
// },
// },
// requestType: 'chatComplete',
// };

// const parameters: PluginParameters<BedrockParameters['credentials']> = {
// ...creds,
// };

// const result = await bedrockPIIHandler(
// context as unknown as PluginContext,
// parameters,
// 'afterRequestHook',
// { env: {} }
// );

// const outputMessage =
// result.transformedData?.response.json.choices[0].message.content;
// expect(result).toBeDefined();
// expect(result.verdict).toBe(true);
// expect(outputMessage).toEqual(
// 'Hello, {NAME}. How are you doing?. I see your email is {EMAIL}\n'
// );
// });

// test('Should work fine with regex redaction for sensitive info', async () => {
// const context = {
// response: {
// json: {
// choices: [
// {
// message: {
// content: 'bedrock-12121, bedrock-12121',
// },
// },
// ],
// },
// },
// requestType: 'chatComplete',
// };

// const parameters: PluginParameters<BedrockParameters['credentials']> = {
// ...creds,
// };

// const result = await bedrockPIIHandler(
// context as unknown as PluginContext,
// parameters,
// 'afterRequestHook',
// { env: {} }
// );

// const outputMessage =
// result.transformedData?.response.json.choices[0].message.content;
// expect(result).toBeDefined();
// expect(result.verdict).toBe(true);
// expect(outputMessage).toBe('{bedrock-id}, {bedrock-id}\n');
// });
});
Loading
Loading