Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Descent 2 port #11

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Update Descent 2 port #11

merged 3 commits into from
Jan 28, 2024

Conversation

JeodC
Copy link
Collaborator

@JeodC JeodC commented Jan 28, 2024 •
edited
Loading

Update for Descent 2

Changelog

  • Change lib to libs
  • Add soundfont (remove dxa for user preference)
  • Add libmodplug for some JelOS builds
  • Sync port to latest from old PortMaster repo
  • Remove log.txt generation since game generates gamelog.txt in conf folder
  • Update readme

Cebion
Cebion previously approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@Cebion Cebion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after review

@Cebion Cebion requested review from kloptops and Tekkenfede January 28, 2024 22:13
Tekkenfede
Tekkenfede requested changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@Tekkenfede Tekkenfede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to remove 2>&1 in the launch command ( ./$GAME -hogdir data 2>&1 ).
Beside that, all good

@JeodC
Copy link
Collaborator Author

JeodC commented Jan 28, 2024

you forgot to remove 2>&1 in the launch command ( ./$GAME -hogdir data 2>&1 ). Beside that, all good

Fixed, thanks for noticing.

Tekkenfede
Tekkenfede approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@Tekkenfede Tekkenfede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Cebion Cebion merged commit e51909f into PortsMaster:main Jan 28, 2024
1 check passed
@JeodC JeodC deleted the descent2 branch January 28, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cebion Cebion Cebion approved these changes

@Tekkenfede Tekkenfede Tekkenfede approved these changes

@kloptops kloptops Awaiting requested review from kloptops kloptops is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeodC @Cebion @Tekkenfede