(FEATURE) Semantic HTML #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- swap single quotes with double and vice–versa - wrap links with an li - replace class name spaces with n-dash - lower case class names
(FEATURE) Semantic HTML
|
Hi, are you going to merge or comment on this pull request? Is this maintained? |
|
@mark-stopka I've even tried to contact this dev on linkedin. I hope they're okay. In the mean time, your welcome to use my fork. |
|
Do you plan to add Bulma Megamenu support? I am currently using this code
<https://github.com/PERLUR/www.perlur.cloud/blob/master/src/wordpress/wp-content/themes/www_perlur_cloud/include/class-bulma-walker.php>
.
--
Best regards / S pozdravem,
BSc. Mark Stopka, BBA
…On Thu, Jun 13, 2019 at 12:40 AM Shaun MacDougall ***@***.***> wrote:
@mark-stopka <https://github.com/mark-stopka> your welcome to use my fork
<https://github.com/shaunmac/Bulma-Navwalker>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AEKMP3H4GDRF627RW43B343P2F3N3A5CNFSM4G3OTZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXR7Y6Y#issuecomment-501480571>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKMP3ES5SA7NJXMCCBFSTLP2F3N3ANCNFSM4G3OTZJA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening remarks
Thank you for a starting this, I just noticed the output html needed a little tweak.
Change made