Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PgBouncer: use service FQDN #635

Merged
merged 1 commit into from
Nov 23, 2022
Merged

PgBouncer: use service FQDN #635

merged 1 commit into from
Nov 23, 2022

Conversation

guidoiaquinti
Copy link
Contributor

@guidoiaquinti guidoiaquinti commented Nov 23, 2022

Description

We currently do not use a FQDN record to connect to pgbouncer. Due to Kubernetes internals, this will translate in several DNS requests before receiving the right answer:

bash-5.1$ nslookup posthog-pgbouncer
Server:		172.20.0.10
Address:	172.20.0.10:53

Name:	posthog-pgbouncer.posthog.svc.cluster.local
Address: 172.20.88.150

** server can't find posthog-pgbouncer.cluster.local: NXDOMAIN

** server can't find posthog-pgbouncer.cluster.local: NXDOMAIN

** server can't find posthog-pgbouncer.svc.cluster.local: NXDOMAIN

** server can't find posthog-pgbouncer.svc.cluster.local: NXDOMAIN

** server can't find posthog-pgbouncer.ec2.internal: NXDOMAIN

** server can't find posthog-pgbouncer.ec2.internal: NXDOMAIN

This PR adds a new posthog.pgbouncer.fqdn definition in our templates, that can be used to directly target the FQDN record.

Related to #628

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

CI is ✅

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@guidoiaquinti guidoiaquinti requested a review from ellie November 23, 2022 10:13
@guidoiaquinti guidoiaquinti marked this pull request as ready for review November 23, 2022 10:21
@guidoiaquinti guidoiaquinti self-assigned this Nov 23, 2022
@guidoiaquinti guidoiaquinti merged commit e3a03bf into main Nov 23, 2022
@guidoiaquinti guidoiaquinti deleted the pgbouncer_fqdn branch November 23, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants