Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service account to backup cronjob #762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorejon
Copy link

@mmorejon mmorejon commented Jul 25, 2023

Description

The service account is needed during the backup process to allow automatic authentication and authorization in public clouds like AWS, GCP or Azure. e.g.: to use workload identity in GKE. This fix avoids mounting secrets with credentials to access to public clouds.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Deployed in a local environment.

$ helm template demo \
  --dependency-update \
  --namespace default \
  ./charts/posthog/          

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant