This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Plugin Running Times Metrics #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ph-metrics
yakkomajuri
changed the title
mariusandra
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
Plenty of code feedback below. Plus one bigger issue: this PR sends a new event to track metrics per every ingested event... which is way too much volume, effectively doubling what we currently do. Instead we must batch this info and just transmit like we currently transmit the instance status reports in the main app.
|
New approach still WIP, need to smoothen some edges and update tests. |
|
The conflicts are running a bit deep so I think I'll just start fresh |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding PostHog metrics on time taken for plugins to run. Allows for charts like this:
This adds timers alongside StatsD, and also:
posthogavailable anywhere and more configurable$snapshotto that list given Don't process $snapshot via plugins #280 but I guess we needonEventbefore we can do that, otherwise it would affect export plugins.$plugin_running_durationhas to be ignored to prevent an infinite event generatorChecklist