Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: finally remove given #1321

Merged
merged 29 commits into from
Jul 29, 2024
Merged

chore: finally remove given #1321

merged 29 commits into from
Jul 29, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Jul 25, 2024

This moves the final files using given to not using given

Which means they can be converted to typescript

I've refactored a little but tried to keep the changes pretty minimal just to get given removed and the tests moved to TS

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jul 27, 2024 9:33pm

Copy link

github-actions bot commented Jul 25, 2024

Size Change: +303 B (+0.03%)

Total Size: 1.16 MB

Filename Size Change
dist/array.full.js 331 kB +101 B (+0.03%)
dist/surveys-preview.js 59.7 kB +101 B (+0.17%)
dist/surveys.js 64.9 kB +101 B (+0.16%)
ℹ️ View Unchanged
Filename Size
dist/array.js 152 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 153 kB
dist/module.js 152 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@pauldambra pauldambra requested a review from daibhin July 27, 2024 22:12
@pauldambra pauldambra marked this pull request as ready for review July 27, 2024 22:12
@daibhin
Copy link
Contributor

daibhin commented Jul 29, 2024

Going to merge this because Paul is out for the week and don't want him to come back to a bunch of merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants