Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track in-flight requests from posthog-js #140

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Track in-flight requests from posthog-js #140

merged 1 commit into from
Dec 1, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Dec 1, 2020

Part of PostHog/posthog#2560
Needed because we lack a feature: PostHog/posthog#2584

Checklist

  • Tests for new code (if applicable)
  • TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

@macobo macobo requested a review from paolodamico December 1, 2020 09:17
paolodamico
paolodamico approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/capture-metrics.js Show resolved Hide resolved
@macobo macobo merged commit b54e0d4 into master Dec 1, 2020
@macobo macobo deleted the track-in-flight-requests branch December 1, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @paolodamico