Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry integration fields #1669

Merged
merged 3 commits into from
Jan 22, 2025
Merged

fix: sentry integration fields #1669

merged 3 commits into from
Jan 22, 2025

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jan 22, 2025

Changes

Cymbal is throwing some errors on exceptions because not all the correct fields are set:

serde error: missing field `platform` at line 1 column 14449
  • Adds the platform field
  • Also fixes a bug where additional properties were not being set in the case where an exception was manually captured but parseErrorAsProperties didn't exist (e.g. exception auto capture wasn't enabled)

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 22, 2025 3:11pm

Copy link

github-actions bot commented Jan 22, 2025

Size Change: +798 B (+0.02%)

Total Size: 3.27 MB

Filename Size Change
dist/array.full.es5.js 265 kB +87 B (+0.03%)
dist/array.full.js 369 kB +79 B (+0.02%)
dist/array.full.no-external.js 368 kB +79 B (+0.02%)
dist/array.js 181 kB +79 B (+0.04%)
dist/array.no-external.js 180 kB +79 B (+0.04%)
dist/main.js 182 kB +79 B (+0.04%)
dist/module.full.js 369 kB +79 B (+0.02%)
dist/module.full.no-external.js 368 kB +79 B (+0.02%)
dist/module.js 181 kB +79 B (+0.04%)
dist/module.no-external.js 180 kB +79 B (+0.04%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 208 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 116 kB
dist/recorder.js 116 kB
dist/surveys-preview.js 67.1 kB
dist/surveys.js 63.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@daibhin daibhin added the bump patch Bump patch version when this PR gets merged label Jan 22, 2025
@daibhin daibhin merged commit bd9904c into main Jan 22, 2025
28 checks passed
@daibhin daibhin deleted the dn-chore/fix-sentry-parsing branch January 22, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants