Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set last reset date as event super property #1671

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

pauldambra
Copy link
Member

i frequently have to diagnose whether a user called reset at an unexpected time and we just have to infer it

Let's set the last reset time on events so we can be more less confused

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 22, 2025 2:45pm

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Jan 22, 2025
@@ -1096,7 +1096,7 @@ export class PostHog {
* // Display the properties
* console.log(posthog.persistence.properties())
*
* @param {Object} properties An associative array of properties to store about the user
* @param {Object} properties properties to store about the user
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't already know what an associative array is and at this point i'm afraid to ask

Copy link
Member

@rafaeelaudibert rafaeelaudibert Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queen's (King's?) English for "hashmap"

Copy link

github-actions bot commented Jan 22, 2025

Size Change: +630 B (+0.02%)

Total Size: 3.27 MB

Filename Size Change
dist/array.full.es5.js 265 kB +63 B (+0.02%)
dist/array.full.js 369 kB +63 B (+0.02%)
dist/array.full.no-external.js 368 kB +63 B (+0.02%)
dist/array.js 181 kB +63 B (+0.03%)
dist/array.no-external.js 180 kB +63 B (+0.04%)
dist/main.js 182 kB +63 B (+0.03%)
dist/module.full.js 369 kB +63 B (+0.02%)
dist/module.full.no-external.js 368 kB +63 B (+0.02%)
dist/module.js 181 kB +63 B (+0.03%)
dist/module.no-external.js 180 kB +63 B (+0.04%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 208 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 116 kB
dist/recorder.js 116 kB
dist/surveys-preview.js 67.1 kB
dist/surveys.js 63.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra merged commit db61389 into main Jan 22, 2025
28 checks passed
@pauldambra pauldambra deleted the fix/pd/thing branch January 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants