Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rrweb-snapshot to dev deps #262

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Add rrweb-snapshot to dev deps #262

merged 2 commits into from
Aug 4, 2021

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Aug 3, 2021

Changes

Potentially closes #252.

@Twixes Twixes added the bump patch Bump patch version when this PR gets merged label Aug 3, 2021
@Twixes Twixes requested a review from yakkomajuri August 3, 2021 08:39
@Twixes Twixes changed the title Add rrweb-snapshot to deps Add rrweb-snapshot to dev deps Aug 3, 2021
@macobo
Copy link
Contributor

macobo commented Aug 3, 2021

The version used is not compatible with the rrweb version - I assume that would break session recording (but only in dev?)

@Twixes
Copy link
Member Author

Twixes commented Aug 3, 2021

It's only for TS definitions, so it should be good either way. This is just to make sure the TS definitions are available.

Copy link
Contributor

@yakkomajuri yakkomajuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're thinking ahead as eventually we'll use an rrweb version that has rrweb-snapshot at 1.1.7. Given it's for TS definitions, should be good.

@Twixes Twixes merged commit 5e9ba30 into master Aug 4, 2021
@Twixes Twixes deleted the rrweb-snapshot-fix branch August 4, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'rrweb-snapshot' or its corresponding type declarations
3 participants