Skip to content

Commit

Permalink
Upgrade development dependencies (#41)
Browse files Browse the repository at this point in the history
All of the dev dependencies were super outdated and the tests wouldn't work.
  • Loading branch information
jclusso authored Feb 7, 2024
1 parent c88b369 commit 6a6b18c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions lib/posthog/feature_flags.rb
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def self.relative_date_parse_for_feature_flag_matching(value)
# Guard against overflow, disallow numbers greater than 10_000
return nil
end

interval = match[2]
if interval == "h"
parsed_dt = parsed_dt - (number/24r)
Expand All @@ -254,7 +254,7 @@ def self.relative_date_parse_for_feature_flag_matching(value)
def self.match_property(property, property_values)
# only looks for matches where key exists in property_values
# doesn't support operator is_not_set

PostHog::Utils.symbolize_keys! property
PostHog::Utils.symbolize_keys! property_values

Expand Down Expand Up @@ -436,7 +436,7 @@ def is_condition_match(flag, distinct_id, condition, properties)
if !rollout_percentage.nil? and _hash(flag[:key], distinct_id) > (rollout_percentage.to_f/100)
return false
end

return true
end

Expand Down Expand Up @@ -531,6 +531,6 @@ def _request(uri, request_object)
logger.debug("Unable to complete request to #{uri}")
throw e
end
end
end
end
end
12 changes: 6 additions & 6 deletions posthog-ruby.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ Gem::Specification.new do |spec|
spec.homepage = 'https://github.com/PostHog/posthog-ruby'
spec.license = 'MIT'
spec.required_ruby_version = '>= 2.0'

spec.add_dependency 'concurrent-ruby', '~> 1'

# Used in the executable testing script
spec.add_development_dependency 'commander', '~> 4.4'

# Used in specs
spec.add_development_dependency 'rake', '~> 10.3'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'tzinfo', '1.2.1'
spec.add_development_dependency 'activesupport', '~> 4.1.11'
spec.add_development_dependency 'rake', '~> 13.1'
spec.add_development_dependency 'rspec', '~> 3.13'
spec.add_development_dependency 'tzinfo', '~> 2.0'
spec.add_development_dependency 'activesupport', '~> 7.1'
if RUBY_VERSION >= '2.0' && RUBY_PLATFORM != 'java'
spec.add_development_dependency 'oj', '~> 3.6.2'
spec.add_development_dependency 'oj', '~> 3.16.3'
end
if RUBY_VERSION >= '2.1'
spec.add_development_dependency 'rubocop', '~> 0.51.0'
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
end

require 'posthog'
require 'active_support/time'
require 'active_support/all'
require 'webmock/rspec'

# Setting timezone for ActiveSupport::TimeWithZone to UTC
Expand Down

0 comments on commit 6a6b18c

Please sign in to comment.