Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-yc-batch-dropdown #10409

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add-yc-batch-dropdown #10409

merged 2 commits into from
Jan 24, 2025

Conversation

kevan-gilbert
Copy link

@kevan-gilbert kevan-gilbert commented Jan 21, 2025

Purpose

  • We currently have no standardized way to collect YC batch information
  • We need consistent batch formatting for accurate reporting
  • This makes it easier for users to select their batch, and ensures data consistency

What's getting changed

  • Added dropdown menu with standardized batch options
  • Organized batches chronologically from newest to oldest
  • Used consistent format (Season YYYY (XNN))
  • Also added a link to the top of the page to a James blog post about being part of YC, to help build empathy/share content

Why:
- Currently no standardized way to collect YC batch information
- Need consistent batch formatting for accurate reporting
- Makes it easier for users to select their batch

How:
- Added dropdown menu with standardized batch options
- Organized batches chronologically from newest to oldest
- Used consistent format (Season YYYY (XNN))
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Jan 23, 2025 6:42pm

@kevan-gilbert
Copy link
Author

Hi @minekansu! You mentioned I should tag you if I go about trying to make this change.
@zlwaterfield, per our convo yesterday, this attempts to get a dropdown for YC applicants so reporting is consistent for the future.
Also my first PR here! 😭🙈🎉

src/pages/yc-onboarding.tsx Outdated Show resolved Hide resolved
src/pages/yc-onboarding.tsx Outdated Show resolved Hide resolved
@minekansu
Copy link
Contributor

minekansu commented Jan 21, 2025

once the field type and options are finalized we need to 2 more things to collect the data correctly:

  1. add new fields and field options to salesforce contact object (I will do this, needs to match exactly)
  2. update Path C in this zap with correct info (once I update salesforce the fields will pop up here, need this right after the updated form goes live on the website to make sure we capture new fields in submissions (should be straightforward but happy to help here!)

- Change from string to enumeration (hopefully did that right)
- Made sure next TWO batches are visible
- Added an "Earlier batches" option
Copy link
Author

@kevan-gilbert kevan-gilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zlwaterfield Zach, hey -- I'm not sure if I'm going about this the right way. Working on incorporating your suggestion about switching to enumeration from string, and including upcoming batches, but I'm unsure if my use of github here has been correct.

Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good to me 👍

Screenshot 2025-01-23 at 1 58 34 PM

@kevan-gilbert kevan-gilbert merged commit aed2d8e into kevan-test- Jan 24, 2025
3 checks passed
@kevan-gilbert kevan-gilbert deleted the add-yc-batch-dropdown branch January 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants