-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke protobuf #9207
Labels
Comments
More context at #8334 |
Did I miss anything @macobo @guidoiaquinti @hazzadous @fuziontech |
I'll take the thumbs up as "no I didn't miss anything" rather than a "yes" response to the question and move on :D |
You didn't miss anything 👍 😉 (I think) |
Well so this was done but now #9368 became a part of this work as well |
This was referenced Apr 11, 2022
yakkomajuri
added
dependencies
Pull requests that update a dependency file
partially live
and removed
dependencies
Pull requests that update a dependency file
partially live
labels
Apr 26, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The persons on events changes we're about to start making require sending new bits of data over through Kafka. These would require changes in the protobuf schema but honestly we might be better off just dropping it at this stage.
@macobo has done some on the initial legwork to support non-protobuf messages on #8333 but I suggest we make the move now.
This would require:
writable_events
A gotcha here is at step 2. What if the user isn't sharded but becomes sharded during this transition? We probably need to retroactively update the sharding async migration to drop and recreate the MV for the JSON topic as well in order to do this so that we write to the correct table.
The text was updated successfully, but these errors were encountered: