Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion): enable json ingestion for self-hosted by default #9448

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

yakkomajuri
Copy link
Contributor

Problem

#9207

Changes

Make JSON ingestion the default

How did you test this code?

We've been running this on Cloud for over a week now

@yakkomajuri yakkomajuri requested a review from tiina303 April 18, 2022 14:07
Copy link
Contributor

@tiina303 tiina303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though not sure tied to the problems we ran into recently

@yakkomajuri
Copy link
Contributor Author

yeah I think I'll hold back on this

@yakkomajuri
Copy link
Contributor Author

The last problem we had was because temporarily we were running a table with kafka_skip_broken_messages=0 and weren't always producing correct timestamps.

Both fixed now. Merging, although this will only take effect with the next release

@yakkomajuri yakkomajuri merged commit 63c783f into master Apr 26, 2022
@yakkomajuri yakkomajuri deleted the yakkomajuri-patch-2 branch April 26, 2022 16:12
fuziontech added a commit that referenced this pull request Apr 28, 2022
* master: (137 commits)
  feat(cohorts): add cohort filter grammars (#9540)
  feat(cohorts): Backwards compatibility of groups and properties (#9462)
  perf(ingestion): unsubscribe from buffer topic while no events are produced to it (#9556)
  fix: Fix `Loading` positioning and `LemonButton` disabled state (#9554)
  test: Speed up backend tests (#9289)
  fix: LemonSpacer -> LemonDivider (#9549)
  feat(funnels): Highlight significant deviations in new funnel viz (#9536)
  docs(storybook): Lemon UI (#9426)
  feat: add support for list of teams to enable the conversion buffer for (#9542)
  chore(onboarding): cleanup framework grid experiment (#9527)
  fix(signup): domain provisioning on cloud (#9515)
  chore: split out async migrations ci (#9539)
  feat(ingestion): enable json ingestion for self-hosted by default (#9448)
  feat(cohort): add all cohort filter selectors to Storybook (#9492)
  feat(ingestion): conversion events buffer consumer (#9432)
  ci(run-backend-tests): remove CH version default (#9532)
  feat: Add person info to events (#9404)
  feat(ingestion): produce to buffer partitioned by team_id:distinct_id (#9518)
  fix: bring latest_migrations.manifest up to date (#9525)
  chore: removes unused feature flag (#9529)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants