Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3000): last updated at overflowing on mobile dashboards #19571

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

RhysSullivan
Copy link
Contributor

@RhysSullivan RhysSullivan commented Jan 3, 2024

Problem

The "last updated at..." for dashboards on mobile overflows causing the screen to be able to be dragged horizontally

Changes

Old:
image

New:
image

useResizeObserver.ts:

  • Updates the generic to be <T extends string> - this is unrelated to this PR but it gives it the correct typing now
  • Unrelated to this PR so I can remove it but I found it while developing and figured I'd fix it

Old:
image

New:
image

Dashboard.scsss

  • Created to allow for using breakpoints to change the flex direction depending on screen size

Dashboard.tsx

  • space-x-4 was removed in the conversion to .scss styling as it wasn't actually applying any styling
  • moves the tailwind styling to .scss

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Manually checked in the local development environment

@RhysSullivan RhysSullivan marked this pull request as ready for review January 3, 2024 05:16
@Twixes Twixes self-requested a review January 3, 2024 09:12
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @RhysSullivan! Just one request from me is that we keep using utility classes here

frontend/src/scenes/dashboard/Dashboard.tsx Outdated Show resolved Hide resolved
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, totally missed this last week, sorry about the delay.
Looks good, let's get this in!

@Twixes Twixes enabled auto-merge (squash) January 16, 2024 15:12
@posthog-bot posthog-bot removed the stale label Jan 17, 2024
@Twixes Twixes merged commit 31a1362 into PostHog:master Jan 17, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants