-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(insights): add migration to convert filters to query #24527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoob13
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! It only needs to update the migration number;
# Conflicts: # latest_migrations.manifest
skoob13
approved these changes
Aug 23, 2024
thmsobrmlr
added
waiting
Prevents stale-bot from marking the PR as stale.
and removed
stale
labels
Sep 2, 2024
# Conflicts: # latest_migrations.manifest
# Conflicts: # posthog/migrations/max_migration.txt
thmsobrmlr
force-pushed
the
filters_to_query_migration
branch
from
January 16, 2025 13:55
814f070
to
4ccc678
Compare
# Conflicts: # posthog/migrations/max_migration.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're currently migrating insight
filters
toquery
in Django shell. Unfortunately self-hosted users are left out.Changes
Does the same for self hosted users.
How did you test this code?