-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rbac middleware #26159
feat: rbac middleware #26159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid! (If i do say so myself).
Should be totally safe but we might want to be ready for a qucik revert just in case
queryset = self.safely_get_queryset(queryset) | ||
except NotImplementedError: | ||
pass | ||
self._in_get_queryset = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh this is nice
665f0a7
to
c04e1ee
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This reverts commit 7b261b9.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bryan Ciaraldi <[email protected]>
Changes
Adding middleware for RBAC. This is mostly pulling the logic from @benjackwhite previous PR: #20864 but updating a bunch more tests and a few logic pieces.
See #24512 for more information.
Key additions:
Many of the changes are test updates for the number of queries. Then we've also added the middleware to the viewsets of Dashboard, Projects, Organizations, Insights, Notebooks, Feature Flags, etc.
More details in Readme to come.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Updated existing tests
Added new tests