feat: better access control object ui #27175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
zlwaterfield
commented
Dec 27, 2024
| const { updateAccessControlMembers } = useAsyncActions(accessControlLogic) | ||
| const { guardAvailableFeature } = useValues(upgradeModalLogic) | ||
|
|
||
| const [modelOpen, setModelOpen] = useState(false) |
There was a problem hiding this comment.
Could be moving into a logic
zlwaterfield
commented
Dec 27, 2024
| const { updateAccessControlRoles } = useAsyncActions(accessControlLogic) | ||
| const { guardAvailableFeature } = useValues(upgradeModalLogic) | ||
|
|
||
| const [modelOpen, setModelOpen] = useState(false) |
There was a problem hiding this comment.
Could be moved into a logic
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
benjackwhite
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow along on all rbac changes: #24512
The access control UI is squished in the sidebar, so this is meant to improve the interface and better fit into the sidebar.
Note: these are all still behind a feature flag and will not be accessible by users
Main changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually