feat: stickiness actors query #27349
Open
+257
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @aspicer! 👋 |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…aspicer/stickiness
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The stickiness actors query only returns the set of users that did the event exactly N times.
Changes
Create a
StickinessActorsQuerywith an operator that allows us to specify exact, gte, or lte.This also adds an optional argument called
intervalCountto the StickinessQuery which allows it to look at things like "2 day" intervals or "4 day" intervals. This is not used in the UI, but is used in the hogql cohort calculations.When interval count is set, the
StickinessQueryalways looks at whole intervals that end at "date_to."What this means is that if it is Jan 15th, and we are looking at Stickiness by month, the intervals will look like "Dec 16th -Jan 15th", "Nov 16th - Dec 15th", "Oct 16th - Nov 15th" etc.
This is to match the behavior of the current cohorts. This might make sense to add a flag to if we want to provide different options in the Stickiness UI, but for now only exists on the backend for cohorts.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Wrote a test, looked at SQL.