Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(legacy): remove legacy retention and insight cache code #27472

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jan 13, 2025

Problem

Let's get rid of legacy endpoints that aren't actively used i.e. path and retention.

Changes

Removes the legacy /insights/retention endpoint. Also removes a bit of unused insight caching code.

How did you test this code?

Used the IDE to find usages of the relevant code paths.

@thmsobrmlr thmsobrmlr changed the title refactor(legacy): remove legacy retention refactor(legacy): remove legacy retention and insight cache code Jan 15, 2025
@thmsobrmlr thmsobrmlr marked this pull request as ready for review January 15, 2025 15:48
@thmsobrmlr thmsobrmlr requested a review from a team January 15, 2025 15:57
Copy link
Contributor

@anirudhpillai anirudhpillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thmsobrmlr thmsobrmlr merged commit 72d4ceb into master Jan 15, 2025
96 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-legacy-retention branch January 15, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants