feat(flags): add flag persistence as a default setting across the org #27527
+418
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated28 snapshot changes in total. 0 added, 28 modified, 0 deleted:
Triggered by this commit. |
havenbarnes
reviewed
Jan 15, 2025
| @@ -315,7 +318,7 @@ export const featureFlagLogic = kea<featureFlagLogicType>([ | |||
| }, | |||
| }, | |||
| })), | |||
| reducers({ | |||
| reducers(() => ({ | |||
There was a problem hiding this comment.
Mostly asking out of curiosity, was this a necessary diff/ did it fix something?
There was a problem hiding this comment.
oops, unnecessary diff. Will remove.
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
…tHog/posthog into feat/enable-default-flag-persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Many customers have been asking for the ability to enable flag persistence as a default behavior in our app, since they use flags in experiments and sometimes forget to check the box, which inevitably leads to the experiments being messed up. See #27514 for more context.
This PR implements #27514.
Changes
Does this work well for both Cloud and self-hosted?
Yawp
How did you test this code?
Manually tested it, see: https://www.loom.com/share/71d59c74f179498e91ef44299d5f6ad4