feat(source-connection-string): Postgres connection string configuration #27559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
EDsCODE
reviewed
Jan 15, 2025
| const sourceFieldToElement = (field: SourceFieldConfig, sourceConfig: SourceConfig, lastValue?: any): JSX.Element => { | ||
| if (field.type === 'text' && field.name === 'connection_string') { |
There was a problem hiding this comment.
ideally field is just determined by "type" but fine leaving this for now and refactoring later if we have a bunch of conditionals
thmsobrmlr
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ion (#27559) Co-authored-by: Eric Duong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Provides a faster way to provide a postgres connection string which can be added to other db providers easily. It avoids users from input each field manually and instead attempts to autofill every other field once a valid connection string is found.
De-risked by not being manditory and not attempting to do 2 way data binding between individual fields
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tried multiple different formats of pg connection strings which parse correctly and provide an optional fast-track to get through this config page as fast as possible.