fix(flags): Do not search orgs by group_key`
#27577
Conversation
The default `searchAlias` is `search`. This is the search query parameter we want as it searches orgs by name as opposed to their group_key. Fixes #26825
haacked
changed the title
group_key`group_key`
haacked
changed the title
group_key`group_key`
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
Nice work! I think this looks fine, your logic is sound, and I'm glad you had a fun learning experience. One comment: have you also tested this on other instances of taxonomic group filters (e.g. insights, etc) on top of simply flags? I can't imagine this would regress that behavior, but it couldn't hurt to be thorough :) |
Yup! I sanity tested in a few other places. I went through it again and took some screenshots. Everything works fine. 
As far as I can tell, the Release Conditions filter is the only place where we have this specific functionality where we have a "Match by" selector that affects the filter. |
When adding a condition to a feature flag, the default property search can also search for groups when "Match by" is set to a group type. This search is defined by a
TaxonomicFilterGroupwith asearchAliasofgroup_key.What this means in practice is rather than searching on a company or project name, it searches on the key, which isn't a very user-friendly thing to search by. It turns out that the default
searchAliasfor aTaxonomicFilterGroupissearchwhich works very well!So this PR is hours of work ending in a one-line deletion. It reminds me of the parable of The Old Engineer and the Hammer. 😆
For context, this feature was introduced in #9299 in a20d57a.
Problem
Closes #26825
Changes
Just removed a line where
searchAliasis overwritten.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually tested it. Check out the exciting video!