feat(retention): filters on start/return event

[anirudhpillai]

Problem

Closes #13235

Changes

• Support filtering the start/return event in retention insight.
• Some UX changes. Soon we'll be adding more features to retention insight to be able to calculate property values so eventually the UI will look similar to below (minus the number of days option in 'condition')

But for now to make incremental upgrades, I've only changed things to be like below

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added tests

[posthog-bot]

📸 UI snapshots have been updated

8 snapshot changes in total. 0 added, 8 modified, 0 deleted:

• chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 4 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[github-actions]

Size Change: +703 B (+0.06%)

Total Size: 1.16 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	1.16 MB	+703 B (+0.06%)

_{compressed-size-action}

[thmsobrmlr]

Works great!

I'd personally want something like "Retention Condition" instead of just "Condition" in the filters heading.

And it would be great to fix the feature that keeps the insight configuration when navigating between insights for the retention entities at some point:

posthog/frontend/src/scenes/insights/InsightNav/insightNavLogic.tsx

Lines 259 to 275 in e6dfdd8

	// // set series (first two entries) from retention target and returning entity
	// if (isRetentionQuery(query)) {
	// const { targetEntity, returningEntity } = query.retentionFilter || {}
	// const series = actionsAndEventsToSeries({
	// events: [
	// ...(targetEntity?.type === 'events' ? [targetEntity as ActionFilter] : []),
	// ...(returningEntity?.type === 'events' ? [returningEntity as ActionFilter] : []),
	// ],
	// actions: [
	// ...(targetEntity?.type === 'actions' ? [targetEntity as ActionFilter] : []),
	// ...(returningEntity?.type === 'actions' ? [returningEntity as ActionFilter] : []),
	// ],
	// })
	// if (series.length > 0) {
	// newCache.series = [...series, ...(cache?.series ? cache.series.slice(series.length) : [])]
	// }
	// }

[thmsobrmlr]

Also it looks like my colors changes broke the retention modal - working on a fix.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ SyntaxError: mismatched input 's' expecting posthog.tasks.tasks.process_query_task View Issue

_{Did you find this useful? React with a 👍 or 👎}