feat(llm-observability): speed up the traces scene #27955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoob13
changed the title
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Peter Kirkham <[email protected]>
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Peter Kirkham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The traces query runner returns a complete list of trace events, including generations, spans, metrics, and feedback. This bloats the payload size, so the speed is meh. Reducing the payload size is a low-hanging optimization (30mb -> 130kb for PostHog).
Changes
traceIdis specified, return the entire payload.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Unit tests, manual testing.