Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web-analytics): Remove Web Vitals from sidebar #28010

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rafaeelaudibert
Copy link
Member

Changes

This is too noisy and it doesn't fit the other dropdowns, let's remove them for now

See https://posthog.slack.com/archives/C011L071P8U/p1738080980717459 (internal)

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Snapshots will be updated for you to see :)

This is too noisy and it doesn't fit the other dropdowns, let's remove them for now
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed Web Vitals dropdown from the Web Analytics navigation item in the sidebar to reduce UI noise and maintain consistency with other navigation items.

  • Removed Web Vitals dropdown option from /frontend/src/layout/navigation-3000/navigationLogic.tsx that was previously shown when WEB_VITALS feature flag was enabled
  • Simplified Web Analytics to be a direct link without additional dropdown options
  • Change aligns with internal discussion about reducing navigation complexity

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +5 B (0%)

compressed-size-action

rafaeelaudibert added a commit to PostHog/posthog.com that referenced this pull request Jan 29, 2025
This was removed in PostHog/posthog#28010, so let's remove from the docs
@rafaeelaudibert rafaeelaudibert enabled auto-merge (squash) January 29, 2025 03:35
@andyvan-ph andyvan-ph removed their request for review January 29, 2025 09:36
@rafaeelaudibert rafaeelaudibert merged commit dcec4d1 into master Jan 29, 2025
102 checks passed
@rafaeelaudibert rafaeelaudibert deleted the remove-web-analytics-sidebar-dropdown branch January 29, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants