Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-3001): fix limit text #28357

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Feb 5, 2025

Problem

  • default limit isn't compared correctly

Changes

  • use the right values for comparison when showing limit copy at the end of table
  • also adjustments on paging and where text is shown

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from a team February 5, 2025 22:22
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adjusts table pagination behavior and improves limit text display logic for data visualization tables in PostHog.

  • Reduced DEFAULT_PAGE_SIZE from 2000 to 500 rows in /frontend/src/queries/nodes/DataVisualization/Components/Table.tsx for better initial load performance
  • Added clearer limit text messaging in /frontend/src/queries/nodes/DataNode/LoadNext.tsx when rows are less than data limit for HogQL visualization queries
  • Fixed conditional text display in LoadPreviewText component to consistently show row count information

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Size Change: 0 B

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.17 MB

compressed-size-action

Copy link
Contributor

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EDsCODE EDsCODE merged commit 67d0b66 into master Feb 5, 2025
106 checks passed
@EDsCODE EDsCODE deleted the editor-3001-adjust-limit-logic branch February 5, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants